Restore circular "unlimited" vision for grid sights #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
added
bug
performance
Grid shapes are not nearly performant enough yet to support this case. The special `range == 0` case is now documented, and the `GridlessGrid.getGridArea()` override relies on it now instead of duplicating the case.
kwvanderlinde
force-pushed
the
bugfix/4980-large-grid-vision
branch
from
62b78ea to
9f12d4e
Compare
cwisniew
approved these changes
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes performance issue for #4980
Description of the Change
This restores the special case where a sight with no distance will produce a circular visible area that goes out to the map's Vision Distance setting. Grid shapes are not nearly performant enough yet to support that case, and it's not clear whether it's even desirable behaviour.
The key to the change is to hit the special case of
range == 0forGrid.getGridArea(). This case is now documented, and the override inGridlessGridrelies on it instead of duplicating the case logic.Possible Drawbacks
None, this bring back long-standing behaviour.
Documentation Notes
N/A
Release Notes
This change is